[PATCH] D104938: OpaquePtr: Reject 'ptr*' again when parsing textual IR

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks accepted this revision.
aeubanks added a comment.

lgtm but with a comment on the newly added method



================
Comment at: llvm/include/llvm/IR/Type.h:231
+  /// True if this is an instance of PointerType that's opaque.
+  bool isOpaquePointerTy() const { return isPointerTy() && !NumContainedTys; }
+
----------------
I have a mild preference to not add these one off sort of methods when we already have lots of code that does `isa<PointerType> && cast<PointerType>(Ty)->isOpaque()`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104938/new/

https://reviews.llvm.org/D104938