[PATCH] D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU.

Fri Jun 25 10:13:47 PDT 2021

holland11 added a comment.

> Please remove all mention of S_WAITCNT_DEPCTR from the patch and then I think it's good to go, thanks again!

Sound good. I'll leave a comment specifying that `s_waitcnt_depctr` is not handled yet, but take it out from everywhere else.

> Just curious, have you run clang-format on this whole patch? Cos these lines look rather short.

I have been running it regularly (and just tried again with no effect). I'll squish that block of comments (vertically) and then run it again so that it can force the correct width. I've been trying to 'get ahead' of clang-format (with respect to comment line length), but I guess I shouldn't be trying to do its job myself.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104730/new/

https://reviews.llvm.org/D104730