[PATCH] D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU.

Fri Jun 25 01:57:24 PDT 2021

foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

> Unfortunately, this does not build. The RetireOOO flag can only be applied to scheduling classes so its let statement can't include any InstRW expressions.
>
> I understand and agree with your point though. Do you have any other ideas to achieve something similar? I'm a rookie when it comes to tablegen so I can't really think of a better way to do it than I'm doing it right now.

Thanks for trying, and no I don't have any better ideas. I think it's fine the way you already have it in the patch.

Please remove all mention of S_WAITCNT_DEPCTR from the patch and then I think it's good to go, thanks again!

================
Comment at: llvm/tools/llvm-mca/lib/AMDGPU/AMDGPUCustomBehaviour.cpp:226
+void AMDGPUCustomBehaviour::generateWaitCntInfo() {
+  // The core logic from this function is taken from
+  // SIInsertWaitcnts::updateEventWaitcntAfter()
----------------
Just curious, have you run clang-format on this whole patch? Cos these lines look rather short.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104730/new/

https://reviews.llvm.org/D104730