[PATCH] D88891: [DebugInfo][InstrRef][1/4] Support transformations that widen or narrow defined values

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer accepted this revision.
StephenTozer added a comment.
This revision is now accepted and ready to land.

One small nit/question attached, otherwise LGTM. Given that we don't always correctly follow subregister changes in `DBG_VALUE`s at the moment, this is a pleasant improvement!



================
Comment at: llvm/lib/CodeGen/MIRParser/MIRParser.cpp:421
     MF.makeDebugValueSubstitution(std::make_pair(Sub.SrcInst, Sub.SrcOp),
-                                  std::make_pair(Sub.DstInst, Sub.DstOp));
   }
----------------
Complete nit, but is there a reason for the `std::make_pair` -> `{}` substitution?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88891/new/

https://reviews.llvm.org/D88891