[PATCH] D104903: [X86] Limit the scaled element type to i64/f64

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:43650
                [](SDValue Op) { return Op.getValueType().is256BitVector(); }) &&
-        scaleShuffleElements(Mask0, 2, ScaledMask0) &&
-        scaleShuffleElements(Mask1, 2, ScaledMask1)) {
+        scaleShuffleElements(Mask0, Size == 8 ? 4 : 2, ScaledMask0) &&
+        scaleShuffleElements(Mask1, Size == 8 ? 4 : 2, ScaledMask1)) {
----------------
Comment didn't save somehow.
Don't you want something like `sizeof(i64)/sizeof(current elt size)` here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104903/new/

https://reviews.llvm.org/D104903