[PATCH] D104782: [AArch64] Custom lower <4 x i8> loads

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 24 13:25:34 PDT 2021


dmgreen added a comment.

In D104782#2839334 <https://reviews.llvm.org/D104782#2839334>, @SjoerdMeijer wrote:

> Fixed that regression by looking if there is one use that is an vector_extract_elt. But I can remove it if you think this is not necessary.

Yeah I wouldn't worry. There may be other ways to fix it if we need, to do with demanded elements of a load. But this code will likely not come up in practice.



================
Comment at: llvm/test/CodeGen/AArch64/neon-extload.ll:49
 
 define i32 @loadExt.i32(<4 x i8>* %ref) {
 ; LE-LABEL: loadExt.i32:
----------------
I would perhaps remove this dot, as dots in function names are a little unusual.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104782/new/

https://reviews.llvm.org/D104782



More information about the llvm-commits mailing list