[PATCH] D104806: [ScalarEvolution] Make getMinusSCEV() fail for unrelated pointers.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

I think the options we have are either we change getMinusSCEV to have this behavior, or we assert the operands to getMinusSCEV aren't pointers and add a new API that has this behavior.  See the current version of D104498 <https://reviews.llvm.org/D104498> for the impact of adding a new getPointerDiff() API.  @reames didn't think the new API was necessary.  I'm sort of on the fence; I don't think adding a new API that's essentially the same thing as getMinusSCEV() is really that useful, but it is easier to audit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104806/new/

https://reviews.llvm.org/D104806