[PATCH] D104806: [ScalarEvolution] Make getMinusSCEV() fail for unrelated pointers.
Max Kazantsev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 24 01:42:00 PDT 2021
mkazantsev added a comment.
I'm generally worried that previously minus SCEV was always returning something, and now it's returning `CouldNotCompute`. We may end up catching multiple failures with unexpected CouldNotCompute in different places, such as implication proof.
Do we know how many situations may lead to this query? I would strongly prefer to assert away this situation and avoid ever making a query to compute minus if SCEVs with different bases. Unless it is, for some reason, a massive amount of work.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104806/new/
https://reviews.llvm.org/D104806
More information about the llvm-commits
mailing list