[PATCH] D104849: [SimplifyCFG] Tail-merging all blocks with `resume` terminator

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri marked 2 inline comments as done.
lebedev.ri added a comment.

@rnk thank you for the review!



================
Comment at: llvm/test/Transforms/SimplifyCFG/tail-merge-resume.ll:67
   call void @quux()
   resume { i8*, i32 } %lp
 }
----------------
rnk wrote:
> rnk wrote:
> > I think it's worth adding an extra block where the resume has a phi operand. That is the dominant pattern coming from clang, so it's important to show that simplifycfg can take a standalone resume block and merge it in.
> Phabricator is being weird, and this isn't highlighted as a diff, but I see that you added the semicommon block as suggested.
That's because i already precommitted that, and rebased the diff over the precommitted change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104849/new/

https://reviews.llvm.org/D104849