[PATCH] D104849: [SimplifyCFG] Tail-merging all blocks with `resume` terminator
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 24 10:57:08 PDT 2021
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, thanks
================
Comment at: llvm/test/Transforms/SimplifyCFG/tail-merge-resume.ll:67
call void @quux()
resume { i8*, i32 } %lp
}
----------------
rnk wrote:
> I think it's worth adding an extra block where the resume has a phi operand. That is the dominant pattern coming from clang, so it's important to show that simplifycfg can take a standalone resume block and merge it in.
Phabricator is being weird, and this isn't highlighted as a diff, but I see that you added the semicommon block as suggested.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104849/new/
https://reviews.llvm.org/D104849
More information about the llvm-commits
mailing list