[PATCH] D104061: [LangRef] clarify the meaning of noimplicitfloat

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.

lgtm

I think the current text is correct and clear, and we can elaborate later if others think more precision is needed.



================
Comment at: llvm/docs/LangRef.rst:1641
+    perform floating-point operations or require access to floating-point
+    registers may still cause floating-point code to be generated.
 ``noinline``
----------------
avl wrote:
> Probably, it makes sense to explicitly describe which cases are "explicit/implicit"? something like this:
> 
> LLVM instructions that perform floating-point operations or require access to floating-point
> registers may still cause floating-point code to be generated for the explicit floating-point cases:
> 
> 1. LLVM instructions that are generated for the expressions from the source code where value has floating-point or vector type.
> 2. LLVM instructions that are generated to satisfy the platform`s ABI requirements.
I think the existing text is clear enough and more concise. Mainly, the proposed text adds a note about generating FP code to satisfy platform ABI requirements. I think the text "LLVM instructions ... that require access to FP registers" captures that well enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104061/new/

https://reviews.llvm.org/D104061