[PATCH] D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU.

Patrick Holland via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 23 13:26:54 PDT 2021


holland11 added a comment.

@foad I implemented some of your suggestions and updated the diff. I did not yet remove the psuedo instruction cases and I did not yet change

  else {
      switch (Inst.getOpcode()) {
      case AMDGPU::S_SENDMSG:
      case AMDGPU::S_SENDMSGHALT:
        ScoreBrackets->updateByEvent(TII, TRI, MRI, SQ_MESSAGE, Inst);
        break;
      case AMDGPU::S_MEMTIME:
      case AMDGPU::S_MEMREALTIME:
        ScoreBrackets->updateByEvent(TII, TRI, MRI, SMEM_ACCESS, Inst);
        break;
      }

to be just a check for the `LGKM_CNT` flag. I am happy to make those changes if you want though and then I'll update the diff again. Let me know what you think!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104730/new/

https://reviews.llvm.org/D104730



More information about the llvm-commits mailing list