[PATCH] D104730: [MCA] [AMDGPU] Adding CustomBehaviour implementation for AMDGPU.

Patrick Holland via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 23 13:24:06 PDT 2021


holland11 updated this revision to Diff 354065.
holland11 added a comment.

Set the `RetireOOO`  flag globally rather than just on the `s_waitcnt` instructions. Also got rid of the `WriteSALUOOO` sched class since `s_waitcnt` can go back to being in the `WriteSALU` class.

These changes caused one of the AMDGPU mca tests to fail since the output is now different. So I updated that test case as well.

Also added the check for `ISAVersion.Major < 7` within `AMDGPUCustomBehaviour::generateWaitCntInfo()`.

Added an example to the end of the original post's body to show demonstrate the effects that the global `RetireOOO` flag has.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104730/new/

https://reviews.llvm.org/D104730

Files:
  llvm/lib/Target/AMDGPU/SISchedule.td
  llvm/test/tools/llvm-mca/AMDGPU/gfx10-double.s
  llvm/tools/llvm-mca/lib/AMDGPU/AMDGPUCustomBehaviour.cpp
  llvm/tools/llvm-mca/lib/AMDGPU/AMDGPUCustomBehaviour.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104730.354065.patch
Type: text/x-patch
Size: 19571 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210623/68d53538/attachment.bin>


More information about the llvm-commits mailing list