[PATCH] D104732: [SCEV] Support signed predicates in applyLoopGuards.

Wed Jun 23 13:06:57 PDT 2021

Meinersbur added a comment.

In D104732#2836630 <https://reviews.llvm.org/D104732#2836630>, @lebedev.ri wrote:

> I'm pretty sure polly is documented as not being the first-tier project, and is excluded from being the reason for reverts.
> If i'm wrong i would like to be corrected.

I hereby correct you.

It was originally proposed by Renato, but in a followup [2] it is made clear that "we should not break it" [3].

[1] https://lists.llvm.org/pipermail/llvm-dev/2020-November/146337.html
[2] https://lists.llvm.org/pipermail/llvm-dev/2020-November/146349.html
[3] https://lists.llvm.org/pipermail/llvm-dev/2020-November/146357.html

In D104732#2836854 <https://reviews.llvm.org/D104732#2836854>, @fhahn wrote:

> Thanks for the heads-up. It looks like the polly test just needs updating. I won't be able to do that in the next 12 hours or so. I'm not sure about the policy with respect to Polly, but if it is blocking you, it would be great if you could revert it in the meantime.

Fixed in https://reviews.llvm.org/rG84046ebd9543d60832d9a580bcbe2e3e5acc3217

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104732/new/

https://reviews.llvm.org/D104732