[PATCH] D104644: [AIX][XCOFF] Support 64-bit relocation writing and related tests

[Maryam via Phabricator via llvm-commits]

MaryamBen marked an inline comment as done.
MaryamBen added a comment.

In D104644#2832538 <https://reviews.llvm.org/D104644#2832538>, @jhenderson wrote:

> This patch from the description is about 64-bit relocation support, so I'm not sure why there's so much changing in the testing. You shouldn't need so many tests for ensuring you have 64-bit relocation support, which implies that the existing tests aren't well designed - they are testing things in a too catch-all manner, and should probably be rewritten to test a small subset of functionality each. Furthermore, why does every test need to cover 64-bit behaviour?

Since I had the fatal error report in 64-bit, I couldn't check the file/section header and symbol table tests. Once I removed this part of the code, I had to implement tests even for the other parts.

  report_fatal_error("64-bit XCOFF object files are not supported yet.");

So maybe I could just change the description or do you have another suggestion ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104644/new/

https://reviews.llvm.org/D104644