[PATCH] D104644: [AIX][XCOFF] Support 64-bit relocation writing and related tests

Maryam via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 23 07:39:01 PDT 2021


MaryamBen marked an inline comment as done.
MaryamBen added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-extern-weak.ll:335
+
+; CHECKSYM64: Symbols [
+; CHECKSYM64-NEXT:   Symbol {
----------------
jhenderson wrote:
> Nit: Line things up for readability.
> 
> That being said, are you able to share these checks with the above set, so that you don't have to have the details listed out twice? If necessary, you could use --check-prefixes to specify multiple prefixes so that you can have common parts, and then separate parts for where the two sets differ.
> 
> The same sort of comments apply in the other tests too.
Thank you for your advice. I have updated all the tests. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104644/new/

https://reviews.llvm.org/D104644



More information about the llvm-commits mailing list