[PATCH] D103597: [AArch64LoadStoreOptimizer] Generate more STPs by renaming registers earlier

[Meera Nakrani via Phabricator via llvm-commits]

MeeraN added a comment.

In D103597#2835448 <https://reviews.llvm.org/D103597#2835448>, @fhahn wrote:

> The question is *why* does it not reach that code? I think we need to understand this first and provide reasons  why skipping the other legality checks is fine. As the mis-compiles indicate, skipping the legality checks does not work well.  Would it be possible to adjust the places that need & can legally do renaming in a more targeted approach?

After taking a look into it, it doesn't reach that line because `!mayAlias(MI, MemInsns, AA)` will return false. I think that is the only check that is missing. But I'm not sure how we could adjust the place where renaming originally takes place as `!mayAlias` will return false for the store instructions we are trying to pair.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103597/new/

https://reviews.llvm.org/D103597