[PATCH] D103597: [AArch64LoadStoreOptimizer] Generate more STPs by renaming registers earlier

Wed Jun 23 02:25:21 PDT 2021

fhahn added a comment.

In D103597#2824734 <https://reviews.llvm.org/D103597#2824734>, @MeeraN wrote:

> @fhahn I don't think that would be possible, at least not in our case, since it won't actually reach that line.

The question is *why* does it not reach that code? I think we need to understand this first and provide reasons  why skipping the other legality checks is fine. As the mis-compiles indicate, skipping the legality checks does not work well.  Would it be possible to adjust the places that need & can legally do renaming in a more targeted approach?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103597/new/

https://reviews.llvm.org/D103597