[PATCH] D104727: [RISCV] Permit RVV stack offsets larger than 12 bits

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 23 01:49:19 PDT 2021


frasercrmck added a comment.

In D104727#2833872 <https://reviews.llvm.org/D104727#2833872>, @jrtc27 wrote:

> Although this isn't even that, this is "Support spilling more than 2047 vector elements"?

Yeah, sort of? It is a fairly generic function used both to set up the stack by decrementing the stack pointer by the RVV stack size and also to fix up frame indices, so it's not strictly equal to spilling this or that number of registers. Stack slots is perhaps a little better, actually, but I could still think of some pathological case where I have relatively few vectors on the stack but with really high alignments that effectively push up the stack size and thus the offsets. Maybe I should just say that we can now support larger "VLEN-factored amounts"? That's sort of meaningless to the casual reader though. Oh what a can of worms.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104727/new/

https://reviews.llvm.org/D104727



More information about the llvm-commits mailing list