[PATCH] D104700: [llvm-objdump] Prevent variable locations to overlap short comments
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 23 00:47:33 PDT 2021
jhenderson added inline comments.
================
Comment at: llvm/test/tools/llvm-objdump/ELF/AArch64/disassemble-print-comments.s:6
# RUN: llvm-mc -filetype=obj -triple=aarch64 -mattr=+sve %s -o %t
-# RUN: llvm-objdump -d --mattr=+sve --no-show-raw-insn %t | FileCheck %s
+# RUN: llvm-objdump -d --mattr=+sve --debug-vars --no-show-raw-insn %t | FileCheck %s
----------------
I think it may be best to do the `--debug-vars` case in a separate invocation, to show that the option has no impact on the comment output.
Same goes for the X86 test case.
================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:224
-int objdump::DbgIndent = 40;
+int objdump::DbgIndent = 52;
----------------
The default is mentioned in the command guide, so the doc needs updating as part of this patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104700/new/
https://reviews.llvm.org/D104700
More information about the llvm-commits
mailing list