[PATCH] D104700: [llvm-objdump] Prevent variable locations to overlap short comments

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin created this revision.
ikudrin added reviewers: MaskRay, ostannard, echristo, jhenderson.
ikudrin added a project: LLVM.
Herald added subscribers: rupprecht, emaste.
ikudrin requested review of this revision.

For now, the source variable locations are printed at about the same space as the comments for disassembled code, which can make some ranges for variables disappear if a line contains comments, for example:

                                          ┠─ bar = W1
  0:  add x0, x2, #2, lsl #12     // =8192┃
  4:  add z31.d, z31.d, #65280    // =0xff00
  8:  nop                                 ┻

The patch shifts the report a bit to allow printing comments up to approximately 16 characters without interferences.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D104700

Files:
  llvm/test/tools/llvm-objdump/ELF/AArch64/disassemble-print-comments.s
  llvm/test/tools/llvm-objdump/ELF/ARM/debug-vars-dwarf4.s
  llvm/test/tools/llvm-objdump/ELF/ARM/debug-vars-wide-chars.s
  llvm/test/tools/llvm-objdump/X86/disassemble-print-comments.s
  llvm/tools/llvm-objdump/llvm-objdump.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104700.353601.patch
Type: text/x-patch
Size: 20741 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210622/a70e796d/attachment-0001.bin>