[PATCH] D104759: Indicate ABI in ARM ELF header flags

[Koutheir Attouchi via Phabricator via llvm-commits]

koutheir added inline comments.


================
Comment at: llvm/include/llvm/MC/MCELFStreamer.h:106
+                                    bool RelaxAll, bool IsThumb,
+                                    bool IsAndroid);
 
----------------
lattner wrote:
> Can this subsume the isandroid" and potentially "is thumb" flags?
I'm not sure. I didn't try to factor out things, in order to keep the changes minimal. A refactoring pass might choose to remove `IsThumb` or `IsAndroid`.


================
Comment at: llvm/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:1204
+  // See: ARMBaseTargetMachine::isTargetHardFloat().
+  if ((TargetTriple.isOSBinFormatMachO() && TargetTriple.getSubArch() == Triple::ARMSubArch_v7em) || TargetTriple
+                                                                                                         .isOSWindows() /* || TargetABI == ARMBaseTargetMachine::ARM_ABI_AAPCS16; */) {
----------------
lattner wrote:
> 80 columns
I executed `git clang-format HEAD~1` before generating this review, so this is the LLVM style.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104759/new/

https://reviews.llvm.org/D104759