[PATCH] D104759: Indicate ABI in ARM ELF header flags
Chris Lattner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 22 21:43:25 PDT 2021
lattner resigned from this revision.
lattner added a comment.
I'm not a competent reviewer for this area anymore, a few driveby comments tho
================
Comment at: llvm/include/llvm/MC/MCELFStreamer.h:106
+ bool RelaxAll, bool IsThumb,
+ bool IsAndroid);
----------------
Can this subsume the isandroid" and potentially "is thumb" flags?
================
Comment at: llvm/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:1204
+ // See: ARMBaseTargetMachine::isTargetHardFloat().
+ if ((TargetTriple.isOSBinFormatMachO() && TargetTriple.getSubArch() == Triple::ARMSubArch_v7em) || TargetTriple
+ .isOSWindows() /* || TargetABI == ARMBaseTargetMachine::ARM_ABI_AAPCS16; */) {
----------------
80 columns
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104759/new/
https://reviews.llvm.org/D104759
More information about the llvm-commits
mailing list