[PATCH] D104137: Optimize lld::elf::ScriptLexer::getLineNumber by avoiding repeated work

[Colin Cross via Phabricator via llvm-commits]

ccross added a comment.

In D104137#2834729 <https://reviews.llvm.org/D104137#2834729>, @MaskRay wrote:

> @ccross How did you end up with a 4MB linker script? Something like `.text : { input0(.text) input1(.text) input2(.text) }` to reorder sections?

I was experimenting with embedding a binary into another binary by converting the loadable sections into blocks of `.WORD(0x....)` in a linker script.  I ended up needing an extra .s file to set the writable/executable flags on the resulting sections, so I moved the data back into the .s file and no longer have a 4MB linker script.  If I could set the flags on sections created from a linker script I could handle the embedding entirely in the linker script.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104137/new/

https://reviews.llvm.org/D104137