[PATCH] D104557: X86: introduce a new `FrameBuilder` type

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

Looks good to me!



================
Comment at: llvm/lib/Target/X86/X86FrameLowering.cpp:1786
     else
-      BuildMI(MBB, MBBI, DL, TII.get(X86::MOV64rr), FramePtr)
+      BuildMI(MBB, FB.MBBI, FB.DL, TII.get(X86::MOV64rr), FramePtr)
           .addReg(SPOrEstablisher);
----------------
As future work, you could probably add `FrameBuilder::BuildMI` methods that return a MachineInstrBuilder and fill in the standard insertion point and debug location, and which perhaps include the `TII.get()` opcode lookup.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104557/new/

https://reviews.llvm.org/D104557