[PATCH] D104575: AMDGPU: Try to eliminate clearing of high bits of 16-bit instructions

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 22 07:07:31 PDT 2021


foad added a comment.

In D104575#2833135 <https://reviews.llvm.org/D104575#2833135>, @arsenm wrote:

> In D104575#2832652 <https://reviews.llvm.org/D104575#2832652>, @foad wrote:
>
>> Looks reasonable to me. I guess there's no way to do this as a DAGCombine instead?
>
> You would need to know exactly how the source node is going to be selected, which you can't know ahead of time We do approximate this for FP instructions already.

I was wondering if combines could be run on the MachineSDNodes immediately after selection. But I see there is nothing like that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104575/new/

https://reviews.llvm.org/D104575



More information about the llvm-commits mailing list