[PATCH] D104701: [ARMInstPrinter] Print the target address of a branch instruction

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 22 06:20:38 PDT 2021


peter.smith added a comment.

In D104701#2832919 <https://reviews.llvm.org/D104701#2832919>, @ikudrin wrote:

> @peter.smith, the patch helped me to spot a couple of suspicious places:
>
> - In `lld/test/ELF/arm-fix-cortex-a8-blx.s`, the target address in the patch points to `<_start+0x4>` while the initial code targets `<_start>`;
> - In `lld/test/ELF/arm-thumb-interwork-thunk.s`, there are check blocks that are not validated, `CHECK-PI-ARM-PLT` and `CHECK-PI-THUMB-PLT`. It looks like they were not checked from the very beginning.
>
> Could you possibly take a look?

I can give it a try. Now on my todo list. I'll have to do this in my spare time so it may take a few days.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104701/new/

https://reviews.llvm.org/D104701



More information about the llvm-commits mailing list