[PATCH] D104681: [lld/mac] Add explicit "no unwind info" entries for functions without unwind info

[Nico Weber via Phabricator via llvm-commits]

thakis marked an inline comment as done.
thakis added a comment.

Thanks!



================
Comment at: lld/MachO/UnwindInfoSection.cpp:300-302
+  for (Symbol *sym : symtab->getSymbols())
+    if (auto *d = dyn_cast<Defined>(sym))
+      markNoUnwindInfo(d);
----------------
int3 wrote:
> I think this might not be necessary given that as far as code section symbols go, all of them can be found as we loop over in `objFile->symbols` below (supposing we remove the `!isExternal()` check). I think the SymtabSection loops over the symbol table only to ensure we emit the synthetic symbols
It's also so we don't emit weak symbols that are in many files more than once. We already dedup'd them via the symbol table, might as well re-use that work.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104681/new/

https://reviews.llvm.org/D104681