[PATCH] D104681: [lld/mac] Add explicit "no unwind info" entries for functions without unwind info

[Jez Ng via Phabricator via llvm-commits]

int3 accepted this revision.
int3 added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: lld/MachO/UnwindInfoSection.cpp:284
+template <class Ptr>
+static void addEntriesForFunctionsWithoutUnwindInfo(
+    std::vector<CompactUnwindEntry<Ptr>> &cuVector) {
----------------
worth adding a comment about why we need this


================
Comment at: lld/MachO/UnwindInfoSection.cpp:300-302
+  for (Symbol *sym : symtab->getSymbols())
+    if (auto *d = dyn_cast<Defined>(sym))
+      markNoUnwindInfo(d);
----------------
I think this might not be necessary given that as far as code section symbols go, all of them can be found as we loop over in `objFile->symbols` below (supposing we remove the `!isExternal()` check). I think the SymtabSection loops over the symbol table only to ensure we emit the synthetic symbols


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104681/new/

https://reviews.llvm.org/D104681