[PATCH] D104218: [ADT] Add StringRef consume_front_lower and consume_back_lower

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D104218#2832592 <https://reviews.llvm.org/D104218#2832592>, @foad wrote:

>> Or should we be kind and do it as a two-stage change, adding new methods with new names and flagging the old ones as deprecated, and removing the deprecated ones in a week or two?
>
> Drive-by comment from a downstream user: I would appreciate you doing it as a two-stage change but there is no need to wait a week or two in between. All I want is a point in git history that I can sync to, that has both the old and new APIs available.

Thanks for the input! Btw, if you happen to be able to check easily in the diff between your downstream fork vs upstream, do you happen to have a lot use of these `_lower()` method calls, outside of code in upstream? (A quick grep in llvm-project shows about only half a dozen per target in llvm/lib/Targets, but a fair bit more in lldb/lld/clang.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104218/new/

https://reviews.llvm.org/D104218