[PATCH] D104218: [ADT] Add StringRef consume_front_lower and consume_back_lower

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 22 01:51:27 PDT 2021


foad added a comment.

> Or should we be kind and do it as a two-stage change, adding new methods with new names and flagging the old ones as deprecated, and removing the deprecated ones in a week or two?

Drive-by comment from a downstream user: I would appreciate you doing it as a two-stage change but there is no need to wait a week or two in between. All I want is a point in git history that I can sync to, that has both the old and new APIs available.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104218/new/

https://reviews.llvm.org/D104218



More information about the llvm-commits mailing list