[PATCH] D102985: [lld][ELF][SPARC] Implement and fixup GOT/PLT relocations

Tue Jun 22 00:28:36 PDT 2021

LemonBoy added a comment.

In D102985#2830779 <https://reviews.llvm.org/D102985#2830779>, @jrtc27 wrote:

> Downstream we turned it into a `std::pair<uint64_t, uint64_t>` (https://github.com/CTSRD-CHERI/llvm-project/blob/de58a2a25c32471b4b3c2aec77fee624e24120cd/lld/ELF/Relocations.cpp#L136-L179), though something more general where it's parameterised on the number of words might be nicer rather than hand-rolling a pair version.

Interesting, I started implementing it in terms of an array of `uint64_t` elements.
Using a `std::pair` looks good to me, it's quite unlikely for `RelExpr` to become bigger than 128 (hopefully). Do you plan on upstreaming this change?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102985/new/

https://reviews.llvm.org/D102985