[PATCH] D104579: [SampleFDO] Add Pass1 of MIRAddFSDiscriminatorsPass before Block-Placement

[Rong Xu via llvm-commits]

On Mon, Jun 21, 2021 at 11:11 AM Wenlei He via Phabricator <
reviews at reviews.llvm.org> wrote:

> wenlei added inline comments.
>
>
> ================
> Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:1468
> +    addPass(createMIRAddFSDiscriminatorsPass(
> +        sampleprof::FSDiscriminatorPass::Pass1));
>    if (addPass(&MachineBlockPlacementID)) {
> ----------------
> wenlei wrote:
> > Wondering once we finalize the spots for adding FS discriminators, do we
> want to replace Pass1, Pass2.. to say BBPlacementDisc, etc. eventually
> An extra profile loader pass is still to be added here coupled with the FS
> disc pass?

Yes, if we want to use the updated profile right after the pass.
If we don't add the FS profie loader pass, the discrimnators in this pass
will be merged into the next FS profiel loader pass.

>
>
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D104579/new/
>
> https://reviews.llvm.org/D104579
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210621/0cfe00d0/attachment.html>