[PATCH] D104579: [SampleFDO] Add Pass1 of MIRAddFSDiscriminatorsPass before Block-Placement

[Wenlei He via Phabricator via llvm-commits]

wenlei added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:1468
+    addPass(createMIRAddFSDiscriminatorsPass(
+        sampleprof::FSDiscriminatorPass::Pass1));
   if (addPass(&MachineBlockPlacementID)) {
----------------
wenlei wrote:
> Wondering once we finalize the spots for adding FS discriminators, do we want to replace Pass1, Pass2.. to say BBPlacementDisc, etc. eventually
An extra profile loader pass is still to be added here coupled with the FS disc pass? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104579/new/

https://reviews.llvm.org/D104579