[PATCH] D104599: [WIP][Attributor] Derive AAFunctionReachability attribute.

[Kuter Dinel via Phabricator via llvm-commits]

kuter added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:8344
+    }
+    return false;
+  }
----------------
jdoerfert wrote:
> Couldn't we add dependences here, maybe keep track of all the AAs above and then add dependences in the false case. removes complexity I think
> 
This is just for checking a single function. In the `updateImpl` method above we have a for loop that goes over unreachable queries.
moving the call to  `recieveUpdates` here  would cause us to call it multiple times which not needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104599/new/

https://reviews.llvm.org/D104599