[PATCH] D104599: [WIP][Attributor] Derive AAFunctionReachability attribute.

[Kuter Dinel via Phabricator via llvm-commits]

kuter added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:8272
+      if (UnreachableQueries.empty())
+        recieveUpdates(A, Edges);
+
----------------
jdoerfert wrote:
> I don't get why we do this conditionally. If we have an unreachable query already, and then a new one comes in, we still now depend on the state of all AAs we asked in the meantime.
We should already have deps if the UnreachableQueries is not empty. I might remove this since this is a very tiny optimization.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104599/new/

https://reviews.llvm.org/D104599