[PATCH] D102852: [RISCV] Fix a crash when lowering split float arguments

[Luís Marques via Phabricator via llvm-commits]

luismarques accepted this revision.
luismarques added a comment.
This revision is now accepted and ready to land.

In D102852#2830495 <https://reviews.llvm.org/D102852#2830495>, @frasercrmck wrote:

> 

I would like to hear from other people, but I should add that another reason I'm wary of treating vectors == aggregates as specified by the psABI because I don't think there's great value in passing vectors `<= 2*XLEN` (`<8 x i8>` on RV64, etc)  packed into one/two register(s). We'd just have to unpack it back into individual elements with shifts and truncates/extends on the caller side anyway since the vector operations would be scalarized by most compilers.

You're right. That's a compelling argument. The patch LGTM.
(Feedback from other people would still be welcome).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102852/new/

https://reviews.llvm.org/D102852