[PATCH] D104013: [LangRef] State that the based-on relation is for pointer typed values only

Harald van Dijk via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 21 05:31:47 PDT 2021


hvdijk added a comment.

Since you pinged, I will repeat my previous objection that you have not yet addressed: you removed the rule stating "A pointer value formed by an ``inttoptr`` is *based* on all pointer values that contribute (directly or indirectly) to the computation of the pointer's value." without a replacement as far as I can see, yet say in your description that this is just a clarification. If you want to modify the rules, please make your description say so. If you just want to clarify the rules, please make sure your changes only do that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104013/new/

https://reviews.llvm.org/D104013



More information about the llvm-commits mailing list