[PATCH] D104425: [AMDGPU] Fixed constexpr expansion to handle multiple uses

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/lib/IR/ReplaceConstant.cpp:87
     SmallPtrSetImpl<Instruction *> *Insts) {
+  SmallPtrSet<ConstantExpr *, 8> Visited;
   for (Use &U : I->operands()) {
----------------
tra wrote:
> Do we need/want to bump the initial set size? I'd assume that it would need to be larger now that we keep track of all operands.
Actually I think even 8 is too much :) Usually expressions are way shorter.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104425/new/

https://reviews.llvm.org/D104425