[PATCH] D104425: [AMDGPU] Fixed constexpr expansion to handle multiple uses

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 16 16:53:19 PDT 2021


tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/IR/ReplaceConstant.cpp:87
     SmallPtrSetImpl<Instruction *> *Insts) {
+  SmallPtrSet<ConstantExpr *, 8> Visited;
   for (Use &U : I->operands()) {
----------------
Do we need/want to bump the initial set size? I'd assume that it would need to be larger now that we keep track of all operands.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104425/new/

https://reviews.llvm.org/D104425



More information about the llvm-commits mailing list