[PATCH] D104576: RegisterCoalescer: Fix iterating through use operands.

[Hendrik Greving via Phabricator via llvm-commits]

hgreving marked an inline comment as done.
hgreving added a comment.

In D104576#2828828 <https://reviews.llvm.org/D104576#2828828>, @jmorse wrote:

> Just so that I understand clearly, the fault here was modifying operands while using range-iteration over the same collection? Was the symptom a crash, or missing output? (Thanks for the catch).

Yes, the iterator was invalidated while updating it. I am not familiar with this particular part of the register coalescer, but stumbled over it when debugging. I think it's a common mistake, thanks for reviewing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104576/new/

https://reviews.llvm.org/D104576