[PATCH] D103282: [MIRParser] Add machine metadata.
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 18 15:45:16 PDT 2021
arsenm added inline comments.
================
Comment at: llvm/lib/CodeGen/MIRParser/MIParser.cpp:1228
+ if (Token.isNot(MIToken::lbrace))
+ return error("expected '{' here");
+ lex();
----------------
Needs tests for the various parse errors
================
Comment at: llvm/test/CodeGen/AArch64/memcpy-scoped-aa.mir:4
+--- |
+ ; ModuleID = 'test/CodeGen/AArch64/memcpy-scoped-aa.ll'
+ source_filename = "test/CodeGen/AArch64/memcpy-scoped-aa.ll"
----------------
Parser/printer tests should go in test/CodeGen/MIR/*
================
Comment at: llvm/test/CodeGen/AMDGPU/memcpy-scoped-aa.mir:221
+registers:
+ - { id: 0, class: vgpr_32, preferred-register: '' }
+ - { id: 1, class: vgpr_32, preferred-register: '' }
----------------
Can you drop the register section and some of the other noise?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103282/new/
https://reviews.llvm.org/D103282
More information about the llvm-commits
mailing list