[PATCH] D102852: [RISCV] Fix a crash when lowering split float arguments

[Luís Marques via Phabricator via llvm-commits]

luismarques added a comment.

In D102852#2824822 <https://reviews.llvm.org/D102852#2824822>, @frasercrmck wrote:

> To be clear, it's fine not to save the floating-point callee-saved registers as that RUN invocation isn't targeting a hard-float ABI. One thing that seems we aren't checking properly is that fastcc still works even if we change `-mattr=+f,+d` to `-mattr=-f,-d`, as it still uses the floating-point registers and instructions. I suppose it should either complain or use a different convention?

Arg. Don't drink and drive and don't do reviews on the weekends. That was faulty testing, it does work as expected, which is a relief.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102852/new/

https://reviews.llvm.org/D102852