[PATCH] D103717: [InstrProfiling][ELF] Make __profd_ private if the function does not use value profiling

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 18 16:12:31 PDT 2021


The LGTM remains the same.

On Fri, Jun 18, 2021 at 4:04 PM Fangrui Song via Phabricator <
reviews at reviews.llvm.org> wrote:

> MaskRay updated this revision to Diff 353121.
> MaskRay added a comment.
>
> switch to the NS==0 approach after seeing `See my prior comment -- your
> previous revision is sound and LGTM. If we go with this version, we do need
> to examine whether static allocation is on or not. Sorry for the trouble.`
> (did not notice in my previous test update...)
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D103717/new/
>
> https://reviews.llvm.org/D103717
>
> Files:
>   llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp
>   llvm/test/Transforms/PGOProfile/indirect_call_profile.ll
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210618/20456087/attachment.html>


More information about the llvm-commits mailing list