[PATCH] D103717: [InstrProfiling][ELF] Make __profd_ private if the function does not use value profiling

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 18 16:04:40 PDT 2021


MaskRay updated this revision to Diff 353121.
MaskRay added a comment.

switch to the NS==0 approach after seeing `See my prior comment -- your previous revision is sound and LGTM. If we go with this version, we do need to examine whether static allocation is on or not. Sorry for the trouble.`
(did not notice in my previous test update...)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103717/new/

https://reviews.llvm.org/D103717

Files:
  llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp
  llvm/test/Transforms/PGOProfile/indirect_call_profile.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103717.353121.patch
Type: text/x-patch
Size: 7259 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210618/21fa1e8f/attachment.bin>


More information about the llvm-commits mailing list