[PATCH] D104440: [X86] Fix bug when X86 stackify pass handle one ArgFPRW.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 17 17:09:30 PDT 2021


craig.topper added inline comments.


================
Comment at: llvm/test/CodeGen/X86/fpstack-call.mir:37
+    ; CHECK: ADJCALLSTACKUP64 0, 0, implicit-def $rsp, implicit-def dead $eflags, implicit-def $ssp, implicit $rsp, implicit $ssp
+    ; CHECK: CHS_F implicit-def $fpsw
+    ; CHECK: ST_FPrr $st0, implicit-def $fpsw, implicit $fpcw
----------------
craig.topper wrote:
> Isn't this just going to crash in hardware? Hardware also checks stack empty.
I guess hardware would just make up a value if the exception is masked?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104440/new/

https://reviews.llvm.org/D104440



More information about the llvm-commits mailing list