[PATCH] D103177: [flang][driver] Extend the `flang` bash script to act as a driver

[Mats Petersson via Phabricator via llvm-commits]

Leporacanthicus accepted this revision.
Leporacanthicus added a comment.
This revision is now accepted and ready to land.

Some minor nit-picks, but nothing wrong - I tested this with some of my fortran code that I've been using for other testing, and it seems to work.



================
Comment at: flang/tools/f18/CMakeLists.txt:70
+
+
 # This flang shell script will only work in a POSIX shell.
----------------
Nit: wouldn't a single blank line be good enough?


================
Comment at: flang/tools/f18/flang.in:229
+  # NOTE: We need `-fc1` to make sure that the frontend driver rather than
+  # compiler drive is used. We also need to make sure that that's the first
+  # flag that the driver will see (otherwise it assumes compiler/toolchain
----------------
nit: driver


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103177/new/

https://reviews.llvm.org/D103177