[PATCH] D104286: [ELF] Restore arm-branch.s test

Wed Jun 16 02:35:20 PDT 2021

peter.smith added a comment.

I've made a suggestion for a comment.

================
Comment at: lld/test/ELF/arm-branch.s:2
 // REQUIRES: arm
 // RUN: llvm-mc -filetype=obj -triple=armv7a-none-linux-gnueabi %s -o %t
 // RUN: echo "SECTIONS { \
----------------
ikudrin wrote:
> MaskRay wrote:
> > add a file-level comment what this test does. it is not obvious.
> Well, as I am not the author of the test, I cannot tell for sure the initial intentions; I merely restored its original functionality and fixed comments. Do you have any suggestions about the description? @peter.smith, maybe you, as the first committer, could help with that?
I think this was one of the first patches I wrote which introduced just enough Arm support to link hello world. As an introductory comment how about.
```
/// Test the Arm state R_ARM_CALL and R_ARM_JUMP24 relocation to Arm state destinations.
/// R_ARM_CALL is used for branch and link (BL)
/// R_ARM_JUMP24 is used for unconditional and conditional branches (B and B<cc>)
/// Relocations defined in https://github.com/ARM-software/abi-aa/blob/main/aaelf32/aaelf32.rst
/// Addend A is always -8 to cancel out Arm state PC-bias of 8 bytes
```

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104286/new/

https://reviews.llvm.org/D104286