[PATCH] D104286: [ELF] Restore arm-branch.s test

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 15 20:45:40 PDT 2021


ikudrin added inline comments.


================
Comment at: lld/test/ELF/arm-branch.s:2
 // REQUIRES: arm
 // RUN: llvm-mc -filetype=obj -triple=armv7a-none-linux-gnueabi %s -o %t
 // RUN: echo "SECTIONS { \
----------------
MaskRay wrote:
> add a file-level comment what this test does. it is not obvious.
Well, as I am not the author of the test, I cannot tell for sure the initial intentions; I merely restored its original functionality and fixed comments. Do you have any suggestions about the description? @peter.smith, maybe you, as the first committer, could help with that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104286/new/

https://reviews.llvm.org/D104286



More information about the llvm-commits mailing list