[PATCH] D104069: [RISCV] Teach vsetvli insertion to remember when predecessors have same AVL and SEW/LMUL ratio if their VTYPEs otherwise mismatch.
Fraser Cormack via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 16 02:26:25 PDT 2021
frasercrmck added inline comments.
================
Comment at: llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp:227
- if (*this == Other)
return *this;
----------------
I'm wondering if removing this use of the `==` operator is a sign we shouldn't have one for these types. Is it confusing to have different meaning of equality? Alternatively perhaps this operator is now unused so can be axed without much discussion.
================
Comment at: llvm/test/CodeGen/RISCV/rvv/vsetvli-insert-crossbb.ll:501
+; We need a vsetvli in the last block because the predecessors have different
+; VTYPEs. The AVL is the same the SEW/LMUL ratio implies the same VLMAX so
+; we don't need to read AVL and can keep VL unchanged.
----------------
Nit but this comment feels like it's missing something in `The AVL is the same the SEW/LMUL ratio`. A comma, or an `and`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104069/new/
https://reviews.llvm.org/D104069
More information about the llvm-commits
mailing list